Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark v1beta1 NetworkPolicy types as deprecated #56425

Merged
merged 2 commits into from
Nov 29, 2017
Merged

Mark v1beta1 NetworkPolicy types as deprecated #56425

merged 2 commits into from
Nov 29, 2017

Conversation

cmluciano
Copy link

What this PR does / why we need it:
Deprecates v1beta1 NetworkPolicy in favor of v1. The default storage is now set to v1 in 1.9.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related #56423

Special notes for your reviewer:

Release note:

deprecate NetworkPolicy v1beta1 API in extensions

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 27, 2017
@cmluciano cmluciano mentioned this pull request Nov 27, 2017
Closed
3 tasks
@wojtek-t wojtek-t assigned caseydavenport and dnardo and unassigned wojtek-t Nov 29, 2017
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2017
@caseydavenport
Copy link
Member

/test pull-kubernetes-unit

@caseydavenport
Copy link
Member

@cmluciano I think we need to get this added to v1.9?

@caseydavenport
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2017
@caseydavenport
Copy link
Member

/assign @thockin

@thockin
Copy link
Member

thockin commented Nov 29, 2017

/approve

@enisoc This is a non-code change - process needed?

@thockin thockin added this to the v1.9 milestone Nov 29, 2017
@thockin thockin added approved-for-milestone kind/documentation Categorizes issue or PR as related to documentation. labels Nov 29, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caseydavenport, cmluciano, thockin

Associated issue: 56423

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. milestone/incomplete-labels labels Nov 29, 2017
@thockin thockin added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Nov 29, 2017
@k8s-github-robot k8s-github-robot removed this from the v1.9 milestone Nov 29, 2017
@enisoc
Copy link
Member

enisoc commented Nov 29, 2017

@thockin Docs change is ok. Adding milestone.

@enisoc enisoc added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. status/in-progress and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 29, 2017
@enisoc enisoc added this to the v1.9 milestone Nov 29, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@caseydavenport @cmluciano @dnardo @lukaszo @thockin

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Pull Request Labels
  • sig/network: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/cleanup: Adding tests, refactoring, fixing old bugs.
Help

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 56497, 56500, 55018, 56544, 56425). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit bb9f27f into kubernetes:master Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukaszo lukaszo

@caseydavenport caseydavenport

@thockin thockin

@dnardo dnardo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@cmluciano @caseydavenport @thockin @k8s-github-robot @enisoc @lukaszo @wojtek-t @dnardo @k8s-ci-robot